Remove some Foundation rules to fix appearance of Craft site#24
Open
jamiefolsom wants to merge 1 commit intomit-history:ulaval-design-integrationfrom
Open
Remove some Foundation rules to fix appearance of Craft site#24jamiefolsom wants to merge 1 commit intomit-history:ulaval-design-integrationfrom
jamiefolsom wants to merge 1 commit intomit-history:ulaval-design-integrationfrom
Conversation
Update index to point at staging, use new bundle. Nuked Foundation rule about Remove some other problematic, too-general Foundation rules. Tweak Foundation to un-bork appearance of button in email form. Tweak Foundation to un-bork appearance of button in email form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @hspier and @blirette,
This PR is based on
ulaval-design-integration, and is intended to run in "production" once the site that's in staging is deployed there.See: http://staging.cfregisters.org/app. That site has this code, and will be deployed soon.
Essentially, I had to remove some CSS rules which are too general, and were messing with
.top-bar, and witha:hover, and.button.Please let me know if you see anything wrong with the site as deployed at: https://performant-software.github.io/analytics/
(I haven't had time to unpack the questions around deployment to the cfrp-laval staging site yet).